zddr commented on code in PR #49041: URL: https://github.com/apache/doris/pull/49041#discussion_r2053780251
########## fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java: ########## @@ -4996,16 +4996,27 @@ public void renameTable(Database db, Table table, String newTableName) throws Dd throw new DdlException("Table name[" + newTableName + "] is already used (in restoring)"); } + if (table.isManagedTable()) { Review Comment: If not checked first, execute db.unregisterTable first, and then check the name in setName (line 5011), it cannot guarantee atomicity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org