zddr commented on code in PR #49041:
URL: https://github.com/apache/doris/pull/49041#discussion_r2053772532
##########
fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java:
##########
@@ -809,16 +818,26 @@ private void replaceTableInternal(Database db, OlapTable
origTable, OlapTable ne
String newTblName = newTbl.getName();
// drop origin table and new table
db.unregisterTable(oldTblName);
+ if (origTable.getType() == TableType.MATERIALIZED_VIEW) {
Review Comment:
If you don't consider the issue of code style, calling deregisterMTMV in
db.unregisterTable is a better choice to avoid missing deregisterMTMV in some
places.
At that time, the main consideration was that deleting information in the
materialized view and removing names in the database were parallel operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
