924060929 commented on code in PR #10786:
URL: https://github.com/apache/doris/pull/10786#discussion_r919614263
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -89,8 +89,8 @@ public void setParent(Group parent) {
this.parent = parent;
}
- public Operator getOperator() {
- return op;
+ public Plan getPlan() {
+ return plan;
Review Comment:
when the plan copyIn to Memo, the plan will be withLogicalProperties and
withChildren(GroupPlan... childrens):
```java
private Plan replaceChildrenToGroupPlan(Plan plan, List<Group>
childrenGroups) {
List<Plan> groupPlanChildren = childrenGroups.stream()
.map(group -> new GroupPlan(group))
.collect(ImmutableList.toImmutableList());
LogicalProperties logicalProperties = plan.getLogicalProperties();
return plan.withChildren(groupPlanChildren)
.withLogicalProperties(Optional.of(logicalProperties));
}
```
so the plan in the memo contains the logicalProperties same as the
logicalProperties in the groupExpression, and replace GroupPlan as children
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
