924060929 commented on code in PR #10786: URL: https://github.com/apache/doris/pull/10786#discussion_r919612449
########## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java: ########## @@ -72,6 +85,16 @@ public LogicalProperties computeLogicalProperties(Plan... inputs) { return new UnboundLogicalProperties(); } + @Override + public Plan withGroupExpression(Optional<GroupExpression> groupExpression) { + return new UnboundRelation(nameParts, groupExpression, Optional.of(logicalProperties)); + } + + @Override + public Plan withLogicalProperties(Optional<LogicalProperties> logicalProperties) { + return new UnboundRelation(nameParts, Optional.empty(), logicalProperties); Review Comment: when the plan is changed, the groupExpression must be clear to tell the memo: I create a new plan, don't skip copyIn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org