deardeng commented on code in PR #47563:
URL: https://github.com/apache/doris/pull/47563#discussion_r1973454041
##########
be/CMakeLists.txt:
##########
@@ -86,6 +86,11 @@ if (DISPLAY_BUILD_TIME)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "time -f 'TimeUsage:
real=%es, user=%Us, sys=%Ss'")
endif()
+if (BUILD_FILE_CACHE_MICROBENCH_TOOL)
+ add_definitions(-DBE_TEST)
Review Comment:
here， in config.cpp
// clang-format off
#ifdef BE_TEST
// test s3
DEFINE_String(test_s3_resource, "resource");
DEFINE_String(test_s3_ak, "ak");
DEFINE_String(test_s3_sk, "sk");
DEFINE_String(test_s3_endpoint, "endpoint");
DEFINE_String(test_s3_region, "region");
DEFINE_String(test_s3_bucket, "bucket");
DEFINE_String(test_s3_prefix, "prefix");
#endif
// clang-format on
##########
common/cpp/s3_rate_limiter.cpp:
##########
@@ -44,7 +44,7 @@ class S3RateLimiter::SimpleSpinLock {
spin_count++;
if (spin_count >= MAX_SPIN_COUNT) {
LOG(WARNING) << "Warning: Excessive spinning detected while
acquiring lock. Spin "
- "count: ";
+ "count: " << spin_count;
Review Comment:
here， in config.cpp
// clang-format off
#ifdef BE_TEST
// test s3
DEFINE_String(test_s3_resource, "resource");
DEFINE_String(test_s3_ak, "ak");
DEFINE_String(test_s3_sk, "sk");
DEFINE_String(test_s3_endpoint, "endpoint");
DEFINE_String(test_s3_region, "region");
DEFINE_String(test_s3_bucket, "bucket");
DEFINE_String(test_s3_prefix, "prefix");
#endif
// clang-format on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
