gavinchou commented on code in PR #47563:
URL: https://github.com/apache/doris/pull/47563#discussion_r1973354710
##########
common/cpp/s3_rate_limiter.cpp:
##########
@@ -44,7 +44,7 @@ class S3RateLimiter::SimpleSpinLock {
spin_count++;
if (spin_count >= MAX_SPIN_COUNT) {
LOG(WARNING) << "Warning: Excessive spinning detected while
acquiring lock. Spin "
- "count: ";
+ "count: " << spin_count;
Review Comment:
do not modify this line?
##########
common/cpp/s3_rate_limiter.cpp:
##########
@@ -44,7 +44,7 @@ class S3RateLimiter::SimpleSpinLock {
spin_count++;
if (spin_count >= MAX_SPIN_COUNT) {
LOG(WARNING) << "Warning: Excessive spinning detected while
acquiring lock. Spin "
- "count: ";
+ "count: " << spin_count;
Review Comment:
fix it with a separate PR
##########
be/CMakeLists.txt:
##########
@@ -86,6 +86,11 @@ if (DISPLAY_BUILD_TIME)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "time -f 'TimeUsage:
real=%es, user=%Us, sys=%Ss'")
endif()
+if (BUILD_FILE_CACHE_MICROBENCH_TOOL)
+ add_definitions(-DBE_TEST)
Review Comment:
why do we need BE_TEST?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
