morrySnow commented on code in PR #10335:
URL: https://github.com/apache/doris/pull/10335#discussion_r906970105
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/plans/physical/PhysicalHeapSort.java:
##########
@@ -32,37 +32,29 @@
/**
* Physical sort plan operator.
*/
-public class PhysicalSort extends PhysicalUnaryOperator {
-
+public class PhysicalHeapSort extends PhysicalUnaryOperator {
+ // Default offset is 0.
private final int offset;
- private final int limit;
-
- private final List<OrderKey> orderList;
-
+ private final List<OrderKey> orderKeys;
private final boolean useTopN;
Review Comment:
useTopN need to be removed. In translator, HeapSort will translate to topN
and MergeSort will translate to normal sort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
