jackwener commented on code in PR #10335:
URL: https://github.com/apache/doris/pull/10335#discussion_r903750067
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/plans/physical/PhysicalSort.java:
##########
@@ -33,22 +33,19 @@
* Physical sort plan operator.
*/
public class PhysicalSort extends PhysicalUnaryOperator {
-
+ // Default offset is 0.
private final int offset;
- private final int limit;
-
private final List<OrderKey> orderList;
-
+ // TODO(wj): Do we need it? If offset is 0 and limit != 0, we can think
it's topN.
Review Comment:
It's is a question worth considering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
