yiguolei commented on code in PR #47620:
URL: https://github.com/apache/doris/pull/47620#discussion_r1947414774
##########
be/src/pipeline/local_exchange/local_exchanger.cpp:
##########
@@ -114,18 +94,14 @@ bool
Exchanger<BlockType>::_dequeue_data(LocalExchangeSourceLocalState* local_st
template <typename BlockType>
void Exchanger<BlockType>::_enqueue_data_and_set_ready(int channel_id,
BlockType&& block) {
- if constexpr (!std::is_same_v<PartitionedBlock, BlockType> &&
- !std::is_same_v<BroadcastBlock, BlockType>) {
- block->ref(1);
+ if constexpr (std::is_same_v<PartitionedBlock, BlockType> ||
+ std::is_same_v<BroadcastBlock, BlockType>) {
+ block.first->record_channel_id(channel_id, false);
+ } else {
+ block->record_channel_id(channel_id, true);
}
if (!_data_queue[channel_id].enqueue(std::move(block))) {
Review Comment:
这个if 还有意义吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
