yiguolei commented on code in PR #47620:
URL: https://github.com/apache/doris/pull/47620#discussion_r1947413639
##########
be/src/pipeline/local_exchange/local_exchanger.h:
##########
@@ -213,13 +213,16 @@ class LocalExchangeSinkLocalState;
*/
struct BlockWrapper {
ENABLE_FACTORY_CREATOR(BlockWrapper);
- BlockWrapper(vectorized::Block&& data_block_) :
data_block(std::move(data_block_)) {}
- ~BlockWrapper() { DCHECK_EQ(ref_count.load(), 0); }
- void ref(int delta) { ref_count += delta; }
- void unref(LocalExchangeSharedState* shared_state, size_t allocated_bytes,
int channel_id) {
- if (ref_count.fetch_sub(1) == 1 && shared_state != nullptr) {
+ BlockWrapper(vectorized::Block&& data_block_, LocalExchangeSharedState*
shared_state_)
Review Comment:
shared_state_ 这种命名方式，都是属性，普通的变量不要这么命名
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
