HappenLee commented on code in PR #47364: URL: https://github.com/apache/doris/pull/47364#discussion_r1929651819
########## be/src/vec/columns/column_dictionary.h: ########## @@ -116,6 +116,10 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> { size_t allocated_bytes() const override { return byte_size(); } + bool has_enough_capacity(const IColumn& src) const override { Review Comment: no need imple the virtual func -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org