BiteTheDDDDt commented on code in PR #47364:
URL: https://github.com/apache/doris/pull/47364#discussion_r1928404600
##########
be/src/vec/columns/column_string.h:
##########
@@ -62,13 +62,13 @@ class ColumnStr final : public COWHelper<IColumn,
ColumnStr<T>> {
static constexpr size_t MAX_STRINGS_OVERFLOW_SIZE = 128;
- void static check_chars_length(size_t total_length, size_t element_number)
{
+ void static check_chars_length(size_t total_length, size_t element_number,
size_t rows = 0) {
if (UNLIKELY(total_length > MAX_STRING_SIZE)) {
throw Exception(
ErrorCode::STRING_OVERFLOW_IN_VEC_ENGINE,
"string column length is too large: total_length={},
element_number={}, "
- "you can set batch_size a number smaller than {} to avoid
this error",
- total_length, element_number, element_number);
+ "you can set batch_size a number smaller than {} to avoid
this error. rows:{}",
+ total_length, element_number, element_number, rows);
Review Comment:
It seems that ‘rows’ and ‘element_number’ have the same meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
