suxiaogang223 commented on code in PR #45881:
URL: https://github.com/apache/doris/pull/45881#discussion_r1926755857
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -2081,19 +2080,17 @@ void
OrcReader::_fill_batch_vec(std::vector<orc::ColumnVectorBatch*>& result,
void OrcReader::_build_delete_row_filter(const Block* block, size_t rows) {
// transactional hive orc delete row
if (_delete_rows != nullptr) {
- _delete_rows_filter_ptr.reset(new IColumn::Filter(rows, 1));
+ _delete_rows_filter_ptr = std::make_unique<IColumn::Filter>(rows, 1);
auto* __restrict _pos_delete_filter_data =
_delete_rows_filter_ptr->data();
- const ColumnInt64& original_transaction_column =
- assert_cast<const ColumnInt64&>(*remove_nullable(
-
block->get_by_name(TransactionalHive::ORIGINAL_TRANSACTION_LOWER_CASE)
- .column));
- const ColumnInt32& bucket_id_column = assert_cast<const ColumnInt32&>(
+ const auto& original_transaction_column = assert_cast<const
ColumnInt64&>(*remove_nullable(
+
block->get_by_name(TransactionalHive::ORIGINAL_TRANSACTION_LOWER_CASE).column));
+ const auto& bucket_id_column = assert_cast<const ColumnInt32&>(
*remove_nullable(block->get_by_name(TransactionalHive::BUCKET_LOWER_CASE).column));
- const ColumnInt64& row_id_column = assert_cast<const ColumnInt64&>(
+ const auto& row_id_column = assert_cast<const ColumnInt64&>(
*remove_nullable(block->get_by_name(TransactionalHive::ROW_ID_LOWER_CASE).column));
for (int i = 0; i < rows; ++i) {
Int64 original_transaction =
original_transaction_column.get_int(i);
- Int32 bucket_id = bucket_id_column.get_int(i);
+ Int64 bucket_id = bucket_id_column.get_int(i);
Review Comment:
I think use auto here is better:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
