suxiaogang223 commented on code in PR #45881:
URL: https://github.com/apache/doris/pull/45881#discussion_r1926757281
##########
be/src/vec/exec/format/column_type_convert.h:
##########
@@ -389,14 +404,15 @@ class CastStringConverter : public ColumnTypeConverter {
bool can_cast = false;
if constexpr (is_decimal_type_const<DstPrimitiveType>()) {
can_cast =
SafeCastDecimalString<DstPrimitiveType>::safe_cast_string(
- string_value.data, string_value.size, &value,
+ string_value.data, cast_set<int>(string_value.size),
&value,
Review Comment:
The `cast_set` will throw exception when value failing cast to int
##########
be/src/vec/exec/format/column_type_convert.h:
##########
@@ -389,14 +404,15 @@ class CastStringConverter : public ColumnTypeConverter {
bool can_cast = false;
if constexpr (is_decimal_type_const<DstPrimitiveType>()) {
can_cast =
SafeCastDecimalString<DstPrimitiveType>::safe_cast_string(
- string_value.data, string_value.size, &value,
+ string_value.data, cast_set<int>(string_value.size),
&value,
Review Comment:
This can be fixed by changing the function safe_cast_string signature, I'll
do this later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
