adonis0147 commented on code in PR #10195:
URL: https://github.com/apache/incubator-doris/pull/10195#discussion_r899859683
##########
be/src/exprs/block_bloom_filter_impl.cc:
##########
@@ -83,17 +85,26 @@ Status BlockBloomFilter::init(const int log_space_bytes,
uint32_t hash_seed) {
return Status::OK();
}
-Status BlockBloomFilter::init_from_directory(int log_space_bytes, const Slice&
directory,
- bool always_false, uint32_t
hash_seed) {
+Status BlockBloomFilter::init_from_directory(int log_space_bytes,
+
butil::IOBufAsZeroCopyInputStream* data,
+ const size_t& data_size, bool
always_false,
+ uint32_t hash_seed) {
Review Comment:
Two points here:
1. The number of arguments a little more.
2. The following snippet (100-107) looks a little bit complex.
If you introduce another `struct` to wrap them, you can make the code more
cleaner.
This comment aimed to enhance the readability other than functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
