cambyzju commented on code in PR #10195:
URL: https://github.com/apache/incubator-doris/pull/10195#discussion_r899806827
##########
be/src/runtime/runtime_filter_mgr.h:
##########
@@ -68,7 +72,8 @@ class RuntimeFilterMgr {
const TQueryOptions& options, int node_id = -1);
// update filter by remote
- Status update_filter(const PPublishFilterRequest* request, const char*
data);
+ Status update_filter(const PPublishFilterRequest* request,
+ butil::IOBufAsZeroCopyInputStream* data);
Review Comment:
```suggestion
const butil::IOBufAsZeroCopyInputStream* data);
```
it is better add const, because we can not modify attachment data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
