qidaye commented on code in PR #44999: URL: https://github.com/apache/doris/pull/44999#discussion_r1909723153
########## extension/logstash/lib/logstash/util/delay_event.rb: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require 'java' + +class DelayEvent + include java.util.concurrent.Delayed + + def initialize(delay, event) + @start_time = Time.now.to_i + delay + @event = event # event style: [documents, http_headers, event_num, req_count] + end + + def get_delay(unit) + delay = @start_time - Time.now.to_i + unit.convert(delay, java.util.concurrent.TimeUnit::SECONDS) + end + + def compare_to(other) + d = self.get_delay(java.util.concurrent.TimeUnit::SECONDS) - other.get_delay(java.util.concurrent.TimeUnit::SECONDS) + if d == 0 + 0 + end + d < 0 ? -1 : 1 + end + + def event + @event + end + + def documents + @event[0] Review Comment: Out of range? ########## extension/logstash/lib/logstash/outputs/doris.rb: ########## @@ -157,50 +183,66 @@ def send_events(events) http_headers["label"] = @label_prefix + "_" + @db + "_" + @table + "_" + Time.now.strftime('%Y%m%d_%H%M%S_%L_' + SecureRandom.uuid) end - req_count = 0 - sleep_for = 1 - while true - response = make_request(documents, http_headers, @http_query, @http_hosts.sample) - - req_count += 1 - response_json = {} - begin - response_json = JSON.parse(response.body) - rescue => e - @logger.warn("doris stream load response: #{response} is not a valid JSON") - end + handle_request(documents, http_headers, event_num, 1) + end + + def sleep_for_attempt(attempt) + sleep_for = attempt**2 + sleep_for = sleep_for <= 60 ? sleep_for : 60 + (sleep_for/2) + (rand(0..sleep_for)/2) + end + + private + def handle_request(documents, http_headers, event_num, req_count) + response = make_request(documents, http_headers, @http_query, @http_hosts.sample) + response_json = {} + begin + response_json = JSON.parse(response.body) + rescue => _ + @logger.warn("doris stream load response is not a valid JSON:\n#{response}") + end + + status = response_json["Status"] Review Comment: If JSON parsing fails, the current logic will add the document to the retry queue, which may lead to max retry. Because the response of parsing failure will not change, and the retry will not succeed. ########## extension/logstash/lib/logstash/util/delay_event.rb: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require 'java' + +class DelayEvent + include java.util.concurrent.Delayed + + def initialize(delay, event) + @start_time = Time.now.to_i + delay + @event = event # event style: [documents, http_headers, event_num, req_count] + end + + def get_delay(unit) + delay = @start_time - Time.now.to_i Review Comment: Time accuracy ########## extension/logstash/lib/logstash/util/delay_event.rb: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require 'java' + +class DelayEvent + include java.util.concurrent.Delayed + + def initialize(delay, event) + @start_time = Time.now.to_i + delay + @event = event # event style: [documents, http_headers, event_num, req_count] + end + + def get_delay(unit) + delay = @start_time - Time.now.to_i + unit.convert(delay, java.util.concurrent.TimeUnit::SECONDS) + end + + def compare_to(other) + d = self.get_delay(java.util.concurrent.TimeUnit::SECONDS) - other.get_delay(java.util.concurrent.TimeUnit::SECONDS) + if d == 0 + 0 + end + d < 0 ? -1 : 1 + end + + def event + @event + end + + def documents + @event[0] + end + + def first_retry + @event[3] == 2 Review Comment: Out of range? ########## extension/logstash/lib/logstash/util/delay_event.rb: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require 'java' + +class DelayEvent + include java.util.concurrent.Delayed + + def initialize(delay, event) + @start_time = Time.now.to_i + delay + @event = event # event style: [documents, http_headers, event_num, req_count] + end + + def get_delay(unit) + delay = @start_time - Time.now.to_i + unit.convert(delay, java.util.concurrent.TimeUnit::SECONDS) + end + + def compare_to(other) + d = self.get_delay(java.util.concurrent.TimeUnit::SECONDS) - other.get_delay(java.util.concurrent.TimeUnit::SECONDS) + if d == 0 + 0 + end + d < 0 ? -1 : 1 Review Comment: If d==0, 0 should be explicitly returned. ```suggestion def compare_to(other) d = self.get_delay(java.util.concurrent.TimeUnit::SECONDS) - other.get_delay(java.util.concurrent.TimeUnit::SECONDS) return 0 if d == 0 d < 0 ? -1 : 1 end ``` ########## extension/logstash/lib/logstash/util/delay_event.rb: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require 'java' + +class DelayEvent + include java.util.concurrent.Delayed + + def initialize(delay, event) Review Comment: 1. delay < 0? 2. event null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
