joker-star-l commented on code in PR #44999: URL: https://github.com/apache/doris/pull/44999#discussion_r1908603100
########## extension/logstash/lib/logstash/outputs/doris.rb: ########## @@ -157,50 +173,59 @@ def send_events(events) http_headers["label"] = @label_prefix + "_" + @db + "_" + @table + "_" + Time.now.strftime('%Y%m%d_%H%M%S_%L_' + SecureRandom.uuid) end - req_count = 0 - sleep_for = 1 - while true - response = make_request(documents, http_headers, @http_query, @http_hosts.sample) - - req_count += 1 - response_json = {} - begin - response_json = JSON.parse(response.body) - rescue => e - @logger.warn("doris stream load response: #{response} is not a valid JSON") - end + handle_request(documents, http_headers, event_num, 1) + end + + def sleep_for_attempt(attempt) + sleep_for = attempt**2 + sleep_for = sleep_for <= 60 ? sleep_for : 60 + (sleep_for/2) + (rand(0..sleep_for)/2) + end + + private + def handle_request(documents, http_headers, event_num, req_count) + response = make_request(documents, http_headers, @http_query, @http_hosts.sample) + response_json = {} + begin + response_json = JSON.parse(response.body) + rescue => _ + @logger.warn("doris stream load response is not a valid JSON:\n#{response}") Review Comment: If an exception occurs, it will be treated as empty json later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org