xinyiZzz commented on code in PR #46266:
URL: https://github.com/apache/doris/pull/46266#discussion_r1900583693
##########
be/src/runtime/result_buffer_mgr.cpp:
##########
@@ -211,7 +211,8 @@ void ResultBufferMgr::cancel_thread() {
// cancel query
for (const auto& id : query_to_cancel) {
- cancel(id, Status::TimedOut("Query tiemout"));
+ cancel(id, Status::Cancelled(fmt::format(
+ "Clean up expired BufferControlBlock, queryId:
{}", print_id(id))));
Review Comment:
done
##########
be/src/runtime/buffer_control_block.cpp:
##########
@@ -170,7 +170,10 @@ BufferControlBlock::BufferControlBlock(TUniqueId id, int
buffer_size, RuntimeSta
}
BufferControlBlock::~BufferControlBlock() {
- cancel(Status::Cancelled("Cancelled"));
+ cancel(Status::Cancelled(fmt::format(
+ "BufferControlBlock is destructed, this is not the expected path,
the correct path is "
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
