yiguolei commented on code in PR #46266:
URL: https://github.com/apache/doris/pull/46266#discussion_r1900562578


##########
be/src/runtime/buffer_control_block.cpp:
##########
@@ -170,7 +170,10 @@ BufferControlBlock::BufferControlBlock(TUniqueId id, int 
buffer_size, RuntimeSta
 }
 
 BufferControlBlock::~BufferControlBlock() {
-    cancel(Status::Cancelled("Cancelled"));
+    cancel(Status::Cancelled(fmt::format(
+            "BufferControlBlock is destructed, this is not the expected path, 
the correct path is "

Review Comment:
   不要这么写,status 类,自带format的功能



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to