w41ter commented on code in PR #46205:
URL: https://github.com/apache/doris/pull/46205#discussion_r1900036772


##########
fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java:
##########
@@ -28,11 +28,13 @@
 public class MarkedCountDownLatch<K, V> extends CountDownLatch {
 
     private Multimap<K, V> marks;
+    private Multimap<K, V> failedMarks;

Review Comment:
   Currently, there is no specific requirement to differentiate between failed 
and unfinished cases, and countDownToZero may not be able to distinguish 
between them fully. Perhaps it would be worth considering your proposed 
solution if the need arises in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to