yujun777 commented on code in PR #46205:
URL: https://github.com/apache/doris/pull/46205#discussion_r1900034680
##########
fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java:
##########
@@ -28,11 +28,13 @@
public class MarkedCountDownLatch<K, V> extends CountDownLatch {
private Multimap<K, V> marks;
+ private Multimap<K, V> failedMarks;
Review Comment:
marks and failedMarks's had overlap effect where they maybe both respent a
failure;
use com.google.common.collect.Table<K, V, Options<Boolean>> marks ?
for its Options<Boolean> value:
1. equals Options.empty() : no response;
2. Options.of(true) : reponse and succ;
3. Options.of(false) : response and failed;
then for function:
1. markedCountDown: Options.empty() => Options.of(true)
2. markedCountDownStatus: Options.empty() => Options.of(status.ok ? true :
false)
3. getLeftMarks: those Options.empty() || Options.of(false);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
