yiguolei commented on code in PR #45675:
URL: https://github.com/apache/doris/pull/45675#discussion_r1893542216
##########
be/src/olap/rowset/segment_v2/bloom_filter_index_reader.cpp:
##########
@@ -45,20 +44,21 @@ int64_t BloomFilterIndexReader::get_metadata_size() const {
(_bloom_filter_index_meta ?
_bloom_filter_index_meta->ByteSizeLong() : 0);
}
-Status BloomFilterIndexReader::_load(bool use_page_cache, bool kept_in_memory)
{
+Status BloomFilterIndexReader::_load(bool use_page_cache, bool kept_in_memory,
+ OlapReaderStatistics* index_load_stats) {
const IndexedColumnMetaPB& bf_index_meta =
_bloom_filter_index_meta->bloom_filter();
_bloom_filter_reader.reset(new IndexedColumnReader(_file_reader,
bf_index_meta));
- RETURN_IF_ERROR(_bloom_filter_reader->load(use_page_cache, kept_in_memory,
_index_load_stats));
- update_metadata_size();
Review Comment:
why delete this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
