yiguolei commented on code in PR #45675:
URL: https://github.com/apache/doris/pull/45675#discussion_r1893542661
##########
be/src/olap/rowset/segment_v2/bloom_filter_index_reader.h:
##########
@@ -48,17 +48,18 @@ class BloomFilterIndexReader : public
MetadataAdder<BloomFilterIndexReader> {
}
Status load(bool use_page_cache, bool kept_in_memory,
- OlapReaderStatistics* _bf_index_load_stats = nullptr);
+ OlapReaderStatistics* bf_index_load_stats);
BloomFilterAlgorithmPB algorithm() { return
_bloom_filter_index_meta->algorithm(); }
// create a new column iterator.
- Status new_iterator(std::unique_ptr<BloomFilterIndexIterator>* iterator);
+ Status new_iterator(std::unique_ptr<BloomFilterIndexIterator>* iterator,
+ OlapReaderStatistics* index_load_stats = nullptr);
Review Comment:
why there is a still defaul value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
