morrySnow commented on code in PR #44726:
URL: https://github.com/apache/doris/pull/44726#discussion_r1879883501
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java:
##########
@@ -51,9 +108,63 @@ protected synchronized void makeSureInitialized() {
}
}
+ @VisibleForTesting
+ public void setTable(Table table) {
+ this.table = table;
+ }
+
+ @VisibleForTesting
+ public void setPartitionColumns(List<Column> partitionColumns) {
+ this.partitionColumns = partitionColumns;
+ }
+
+ @VisibleForTesting
+ public List<Column> getSchema() {
+ Schema schema = table.schema();
+ List<Types.NestedField> columns = schema.columns();
+ List<Column> tmpSchema =
Lists.newArrayListWithCapacity(columns.size());
+ for (Types.NestedField field : columns) {
+ tmpSchema.add(new Column(field.name().toLowerCase(Locale.ROOT),
Review Comment:
why to lowercase?
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/mtmv/MTMVTask.java:
##########
@@ -176,6 +177,11 @@ public void run() throws JobException {
this.relation = MTMVPlanUtil.generateMTMVRelation(mtmv, ctx);
beforeMTMVRefresh();
if (mtmv.getMvPartitionInfo().getPartitionType() !=
MTMVPartitionType.SELF_MANAGE) {
+ MTMVRelatedTableIf relatedTable =
mtmv.getMvPartitionInfo().getRelatedTable();
+ if (!relatedTable.isValidRelatedTable()) {
+ throw new JobException("MTMV " + mtmv.getName() + "'s
related table " + relatedTable.getName()
+ + " is not a valid related table anymore, stop
refreshing.");
Review Comment:
could we also print invalid reason here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
