kaka11chen commented on code in PR #45251: URL: https://github.com/apache/doris/pull/45251#discussion_r1882046492
########## fe/fe-core/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ########## @@ -2065,7 +2064,7 @@ public List<String> listPartitionNames(String catName, String db_name, String tb @Override public int getNumPartitionsByFilter(String db_name, String tbl_name, String filter) throws TException { - return getNumPartitionsByFilter(getDefaultCatalog(conf), db_name, tbl_name, filter); + return client.get_num_partitions_by_filter(db_name, tbl_name, filter); Review Comment: @morningman Does it need prepend catalog name? ########## fe/fe-core/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ########## @@ -1682,8 +1682,7 @@ public List<Partition> listPartitionsByFilter(String db_name, String tbl_name, @Override public List<Partition> listPartitionsByFilter(String catName, String db_name, String tbl_name, String filter, int max_parts) throws TException { - List<Partition> parts =client.get_partitions_by_filter(prependCatalogToDbName( - catName, db_name, conf), tbl_name, filter, shrinkMaxtoShort(max_parts)); + List<Partition> parts =client.get_partitions_by_filter(db_name, tbl_name, filter, shrinkMaxtoShort(max_parts)); Review Comment: @morningman Does it need prepend catalog name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org