kaka11chen commented on code in PR #45251:
URL: https://github.com/apache/doris/pull/45251#discussion_r1882042829
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java:
##########
@@ -114,6 +119,12 @@ public class HiveMetaStoreCache {
private final ExecutorService refreshExecutor;
private final ExecutorService fileListingExecutor;
+ // cache from <dbname-tblname> -> <num of partitions>
+ private LoadingCache<PartitionNumCacheKey, Integer> partitionNumCache;
+
+ // cache from <dbname-tblname-filter> -> <values of partitions>
+ private LoadingCache<FilterPartitionValueCacheKey, Map<Long,
PartitionItem>> filterPartitionValuesCache;
Review Comment:
- These two caches should can be disable by size = 0 or `enable` flag, and
the default value may be disabled better.
- Can we merge `partitionValuesCache` to `filterPartitionValuesCache`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
