feiniaofeiafei commented on code in PR #45065:
URL: https://github.com/apache/doris/pull/45065#discussion_r1873090352
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java:
##########
@@ -315,6 +316,9 @@ public Lead visitLead(Lead lead, Void ctx) {
*/
@Override
public FirstOrLastValue visitFirstValue(FirstValue firstValue, Void ctx) {
+ if (firstValue.arity() == 2 &&
firstValue.child(1).equals(BooleanLiteral.TRUE)) {
Review Comment:
The second parameter can be a constant expression, but it will be
constant-folded. When visitFirstValue has no second parameter or the second
parameter is false, there should be no problem and it can be left unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
