morrySnow commented on code in PR #45065:
URL: https://github.com/apache/doris/pull/45065#discussion_r1871582399
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java:
##########
@@ -315,6 +316,9 @@ public Lead visitLead(Lead lead, Void ctx) {
*/
@Override
public FirstOrLastValue visitFirstValue(FirstValue firstValue, Void ctx) {
+ if (firstValue.arity() == 2 &&
firstValue.child(1).equals(BooleanLiteral.TRUE)) {
Review Comment:
does the second child could be any expression or only could be boolean
literal? not see any check in `FirstOrLastValue`. Should we remove
`visitFirstValue` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
