HappenLee commented on code in PR #44716:
URL: https://github.com/apache/doris/pull/44716#discussion_r1865692262
##########
fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java:
##########
@@ -216,9 +218,36 @@ public TRuntimeFilterDesc toThrift() {
tFilter.setIsBroadcastJoin(isBroadcastJoin);
tFilter.setHasLocalTargets(hasLocalTargets);
tFilter.setHasRemoteTargets(hasRemoteTargets);
+
+ boolean hasSerialTargets = false;
for (RuntimeFilterTarget target : targets) {
tFilter.putToPlanIdToTargetExpr(target.node.getId().asInt(),
target.expr.treeToThrift());
+ hasSerialTargets = hasSerialTargets
+ || (target.node.isSerialOperator() &&
target.node.fragment.useSerialSource(ConnectContext.get()));
}
+
+ boolean enableSyncFilterSize = ConnectContext.get() != null
+ &&
ConnectContext.get().getSessionVariable().enableSyncRuntimeFilterSize();
+ // there are two cases need merge rf
+ // 1. hasRemoteTargets is true means join type is hash shuffle join
then rf will
Review Comment:
`hasRemoteTargets` not means `shuffle join`, maybe `broadcast`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
