Gabriel39 commented on code in PR #44716:
URL: https://github.com/apache/doris/pull/44716#discussion_r1865174470
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1366,21 +1365,10 @@ Status IRuntimeFilter::init_with_desc(const
TRuntimeFilterDesc* desc, const TQue
params.runtime_bloom_filter_max_size =
options->__isset.runtime_bloom_filter_max_size
?
options->runtime_bloom_filter_max_size
: 0;
- auto sync_filter_size = desc->__isset.sync_filter_size &&
desc->sync_filter_size;
- // We build runtime filter by exact distinct count if all of 3 conditions
are met:
- // 1. Only 1 join key
- // 2. Bloom filter
- // 3. Size of all bloom filters will be same (size will be sync or this is
a broadcast join).
- params.build_bf_exactly =
- build_bf_exactly && (_runtime_filter_type ==
RuntimeFilterType::BLOOM_FILTER ||
- _runtime_filter_type ==
RuntimeFilterType::IN_OR_BLOOM_FILTER);
+ params.build_bf_exactly = desc->build_bf_exactly;
Review Comment:
```suggestion
params.build_bf_exactly = desc->__isset.build_bf_exactly &&
desc->build_bf_exactly;
```
##########
fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java:
##########
@@ -597,6 +624,14 @@ public void addTarget(RuntimeFilterTarget target) {
targets.add(target);
}
+ public void setSingleEq(int eqJoinConjunctsNumbers) {
+ singleEq = (eqJoinConjunctsNumbers == 1);
+ }
+
+ public boolean getSingleEq() {
Review Comment:
unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
