HappenLee commented on code in PR #43885:
URL: https://github.com/apache/doris/pull/43885#discussion_r1842120711
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -996,14 +996,13 @@ Status IRuntimeFilter::publish(bool publish_local) {
auto send_to_remote = [&](IRuntimeFilter* filter) {
TNetworkAddress addr;
DCHECK(_state != nullptr);
- RETURN_IF_ERROR(_state->runtime_filter_mgr->get_merge_addr(&addr));
+
RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr));
return filter->push_to_remote(&addr);
};
- auto send_to_local = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper)
{
- std::vector<std::shared_ptr<IRuntimeFilter>> filters;
-
RETURN_IF_ERROR(_state->runtime_filter_mgr->get_consume_filters(_filter_id,
filters));
- DCHECK(!filters.empty());
- // push down
+ auto send_to_local = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper,
bool global) {
+ std::vector<std::shared_ptr<IRuntimeFilter>> filters =
Review Comment:
why not add new api `get_consume_filters` ？ why not find not return error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
