HappenLee commented on code in PR #43885:
URL: https://github.com/apache/doris/pull/43885#discussion_r1842150584
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1095,13 +1097,16 @@ class SyncSizeClosure : public
AutoReleaseClosure<PSendFilterSizeRequest,
Status IRuntimeFilter::send_filter_size(RuntimeState* state, uint64_t
local_filter_size) {
DCHECK(is_producer());
- if (_need_local_merge) {
+ if
(!_state->global_runtime_filter_mgr()->get_consume_filters(_filter_id).empty())
{
LocalMergeFilters* local_merge_filters = nullptr;
-
RETURN_IF_ERROR(_state->runtime_filter_mgr->get_local_merge_producer_filters(
+
RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters(
_filter_id, &local_merge_filters));
std::lock_guard l(*local_merge_filters->lock);
local_merge_filters->merge_size_times--;
local_merge_filters->local_merged_size += local_filter_size;
+ if (_has_local_target) {
Review Comment:
the code is wired, why here use global rf mgr get filter? has_local_target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
