yiguolei commented on code in PR #43515: URL: https://github.com/apache/doris/pull/43515#discussion_r1835889308
########## be/test/vec/core/column_complex_test.cpp: ########## @@ -153,6 +181,21 @@ TEST_F(ColumnBitmapTest, ColumnBitmapReadWrite) { EXPECT_TRUE(bitmap.contains(1000000)); } +TEST_F(ColumnBitmapTest, OperatorValidate) { + auto column = _bitmap_type.create_column(); + + // empty column + check_serialize_and_deserialize(column); + + // bitmap with lots of rows + const size_t row_size = 20000; + auto& data = assert_cast<ColumnBitmap&>(*column.get()).get_data(); + data.resize(row_size); + check_serialize_and_deserialize(column); + + check_field_type(column); Review Comment: Not only check the return type. 1. build a bitmap value and insert into the column 2. get the filed value from column and check the value 3. check the type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org