yiguolei commented on code in PR #43515:
URL: https://github.com/apache/doris/pull/43515#discussion_r1835228631
##########
be/src/vec/columns/column_complex.h:
##########
@@ -129,13 +131,14 @@ class ColumnComplexType final : public COWHelper<IColumn,
ColumnComplexType<T>>
MutableColumnPtr clone_resized(size_t size) const override;
void insert(const Field& x) override {
+ DCHECK_EQ(x.get_type(), Field::TypeToEnum<T>::value);
const T& s = doris::vectorized::get<const T&>(x);
data.push_back(s);
}
Field operator[](size_t n) const override {
assert(n < size());
- return {reinterpret_cast<const char*>(&data[n]), sizeof(data[n])};
+ return Field(data[n]);
Review Comment:
should add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
