csun5285 commented on code in PR #42680:
URL: https://github.com/apache/doris/pull/42680#discussion_r1827350825
##########
be/src/olap/compaction.cpp:
##########
@@ -826,6 +826,7 @@ Status
CompactionMixin::construct_output_rowset_writer(RowsetWriterContext& ctx)
ctx.tablet_schema = _cur_tablet_schema;
ctx.newest_write_timestamp = _newest_write_timestamp;
ctx.write_type = DataWriteType::TYPE_COMPACTION;
+ ctx.tablet = _tablet;
Review Comment:
CloudCompactionMixin::construct_output_rowset_writer()
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -246,6 +246,31 @@ Status SegmentWriter::_create_column_writer(uint32_t cid,
const TabletColumn& co
#undef CHECK_FIELD_TYPE
+ if (_tablet) {
+ opts.data_page_size = _tablet->tablet_meta()->storage_page_size();
+ }
Review Comment:
else {
DCHECK(false);
}
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -241,6 +241,31 @@ Status
VerticalSegmentWriter::_create_column_writer(uint32_t cid, const TabletCo
#undef CHECK_FIELD_TYPE
+ if (_tablet) {
+ opts.data_page_size = _tablet->tablet_meta()->storage_page_size();
+ }
Review Comment:
else {
DCHECK(false);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
