github-actions[bot] commented on code in PR #42680:
URL: https://github.com/apache/doris/pull/42680#discussion_r1827336288
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -983,6 +989,7 @@ bool operator==(const TabletMeta& a, const TabletMeta& b) {
return false;
if (a._time_series_compaction_level_threshold !=
b._time_series_compaction_level_threshold)
return false;
+ if (a._storage_page_size != b._storage_page_size) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (a._storage_page_size != b._storage_page_size) { return false;
}
```
##########
be/src/olap/tablet_meta.h:
##########
@@ -293,6 +294,11 @@ class TabletMeta : public MetadataAdder<TabletMeta> {
int64_t avg_rs_meta_serialize_size() const { return
_avg_rs_meta_serialize_size; }
+ void set_storage_page_size(int64_t storage_page_size) {
+ _storage_page_size = storage_page_size;
+ }
+ int64_t storage_page_size() const { return _storage_page_size; }
+
private:
Status _save_meta(DataDir* data_dir);
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/olap/tablet_meta.h:296:** previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
