gavinchou commented on code in PR #42949:
URL: https://github.com/apache/doris/pull/42949#discussion_r1823823159
##########
be/src/olap/olap_common.h:
##########
@@ -416,7 +417,11 @@ struct RowsetId {
auto [_, ec] = std::from_chars(rowset_id_str.data(),
rowset_id_str.data() +
rowset_id_str.length(), high);
if (ec != std::errc {}) [[unlikely]] {
- LOG(FATAL) << "failed to init rowset id: " << rowset_id_str;
+ LOG(WARNING) << "failed to init rowset id: " << rowset_id_str;
+ high = []() {
+ std::mt19937_64 rg(std::random_device {}());
+ return std::uniform_int_distribution<int64_t>()(rg);
Review Comment:
use the original rowsetid generator instead of a rng here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
