gavinchou commented on code in PR #42949:
URL: https://github.com/apache/doris/pull/42949#discussion_r1828021053
##########
be/src/olap/olap_common.h:
##########
@@ -416,7 +418,8 @@ struct RowsetId {
auto [_, ec] = std::from_chars(rowset_id_str.data(),
rowset_id_str.data() +
rowset_id_str.length(), high);
if (ec != std::errc {}) [[unlikely]] {
- LOG(FATAL) << "failed to init rowset id: " << rowset_id_str;
+ LOG(WARNING) << "failed to init rowset id: " << rowset_id_str;
+ high = unique_rowset_id_next_high();
Review Comment:
why not just
```
RowsetId rsid = next_rowset_id();
init(1, rsid.high, 0, 0);
```
No need to introduce an extra function `UniqueRowsetIdGenerator::next_high()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
