zhiqiang-hhhh commented on code in PR #42136: URL: https://github.com/apache/doris/pull/42136#discussion_r1810325915
########## be/src/vec/functions/array/function_array_aggregation.cpp: ########## @@ -275,34 +312,57 @@ struct AggregateFunction<AggregateFunctionImpl<AggregateOperation::MAX>> { struct NameArraySum { static constexpr auto name = "array_sum"; }; +struct NameArraySumDecimal256 { + static constexpr auto name = "array_sum_decimal256"; Review Comment: ``` #include "vec/aggregate_functions/aggregate_function.h" use DECIMAL256_FUNCTION_SUFFIX instead of another literal. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org