yiguolei commented on code in PR #42136: URL: https://github.com/apache/doris/pull/42136#discussion_r1809755443
########## be/src/vec/aggregate_functions/aggregate_function.h: ########## @@ -34,10 +34,16 @@ namespace doris::vectorized { +const static std::string DECIMAL256_FUNCTION_SUFFIX {"_decimal256"}; + class Arena; class IColumn; class IDataType; +struct AggregateFunctionAttr { + bool enable_decimal256 {}; Review Comment: make it clear. = true or = false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org