morningman commented on code in PR #9145:
URL: https://github.com/apache/incubator-doris/pull/9145#discussion_r856927481
##########
be/src/runtime/thread_context.h:
##########
@@ -111,10 +123,15 @@ class ThreadContext {
}
const std::string& task_id() const { return _task_id; }
- const std::thread::id& thread_id() const { return _thread_id; }
- const std::string& thread_id_str() const { return _thread_id_str; }
+ const std::string& thread_id_str() const { return _thread_id; }
const TUniqueId& fragment_instance_id() const { return
_fragment_instance_id; }
+ std::string get_thread_id() {
+ std::stringstream ss;
Review Comment:
better not using stringstream. use fmt instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
