xzj7019 commented on code in PR #40878: URL: https://github.com/apache/doris/pull/40878#discussion_r1777109992
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ReplacePredicate.java: ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.common.Pair; +import org.apache.doris.nereids.CascadesContext; +import org.apache.doris.nereids.analyzer.Scope; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.rules.analysis.ExpressionAnalyzer; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.Like; +import org.apache.doris.nereids.trees.expressions.Not; +import org.apache.doris.nereids.trees.expressions.Or; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.ExpressionTrait; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.types.DecimalV2Type; +import org.apache.doris.nereids.types.DecimalV3Type; +import org.apache.doris.nereids.util.ImmutableEqualSet; +import org.apache.doris.nereids.util.PredicateInferUtils; +import org.apache.doris.nereids.util.TypeCoercionUtils; + +import com.google.common.collect.ImmutableList; +import org.jetbrains.annotations.Nullable; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/**ReplacePredicate*/ +public class ReplacePredicate { + private static List<Expression> getAllSubExpressions(Expression expr) { + List<Expression> subExpressions = new ArrayList<>(); + getAllSubExpressions(expr, subExpressions); + return subExpressions; + } + + private static void getAllSubExpressions(Expression expr, List<Expression> res) { + res.add(expr); + if (expr.children().size() != 1) { + Set<Slot> slots = expr.getInputSlots(); + if (slots.size() == 1) { + res.add(slots.iterator().next()); + } + return; + } + getAllSubExpressions(expr.child(0), res); + } + + /** fill map exprPredicates : expression and all its corresponding predicates */ + private static class PredicatesCollector extends ExpressionVisitor<Void, Map<Expression, Set<Expression>>> { + public static PredicatesCollector INSTANCE = new PredicatesCollector(); + + @Override + public Void visit(Expression expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitOr(Or expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitInPredicate(InPredicate inPredicate, Map<Expression, Set<Expression>> context) { + if (!validInPredicate(inPredicate)) { + return null; + } + for (Expression expr : getAllSubExpressions(inPredicate.getCompareExpr())) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(inPredicate); + } + return null; + } + + @Override + public Void visitComparisonPredicate(ComparisonPredicate comparisonPredicate, + Map<Expression, Set<Expression>> context) { + if (!validComparisonPredicate(comparisonPredicate)) { + return null; + } + // It is believed that 1<a has been rewritten as a>1 + for (Expression expr : getAllSubExpressions(comparisonPredicate.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(comparisonPredicate); + } + return null; + } + + @Override + public Void visitNot(Not not, Map<Expression, Set<Expression>> context) { + if (not.child(0) instanceof InPredicate && validInPredicate((InPredicate) not.child(0)) + || not.child(0) instanceof ComparisonPredicate + && validComparisonPredicate((ComparisonPredicate) not.child(0))) { + for (Expression expr : getAllSubExpressions(not.child(0).child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(not); + } + } + return null; + } + + @Override + public Void visitLike(Like like, Map<Expression, Set<Expression>> context) { + if (!(like.child(1) instanceof Literal)) { + return null; + } + for (Expression expr : getAllSubExpressions(like.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(like); + } + return null; + } + + private boolean validComparisonPredicate(ComparisonPredicate comparisonPredicate) { + return comparisonPredicate.right() instanceof Literal; + } + + private boolean validInPredicate(InPredicate inPredicate) { + return inPredicate.isLiteralChildren(); + } + } + + /* replaceToThis: find all predicates that replaceToThis can deduce (e.g. replaceToThis = b) + equalSet: the equivalent set of replaceToThis (e.g. equalSet: a=b) + exprPredicates: expression and all its corresponding predicates (e.g. such as {a: [a<10, a>1], b: [b in (1, 2)]}) + return: all predicates that replaceToThis can deduce (return b<10, b>1) */ + private static <T extends Expression> Set<Expression> getEqualSetAndDoReplace(T replaceToThis, Set<T> equalSet, + Map<? extends Expression, Set<Expression>> exprPredicates) { + ExpressionAnalyzer analyzer = new ReplaceAnalyzer(null, new Scope(ImmutableList.of()), null, false, false); + Set<Expression> res = new LinkedHashSet<>(); + for (T equals : equalSet) { + Map<Expression, Expression> replaceMap = new HashMap<>(); + replaceMap.put(equals, replaceToThis); + if (!exprPredicates.containsKey(equals)) { + continue; + } + for (Expression predicate : exprPredicates.get(equals)) { + Expression newPredicates = Replacer.INSTANCE.replace(predicate, replaceMap); + try { + Expression analyzed = analyzer.analyze(newPredicates); + res.add(analyzed.withInferred(true)); + } catch (Exception e) { + // has cast error, just not infer and do nothing + continue; + } + } + } + return res; + } + + /* Extract the equivalence relationship a=b, and when case (d_tinyint as int)=d_int is encountered, + remove the cast and extract d_tinyint=d_int + EqualPairs is the output parameter and the equivalent pair of predicate derivation input, + which is used to ensure that the derivation + does not generate repeated equivalent conditions, such as a=b and b=a */ + private static ImmutableEqualSet<Slot> findEqual(Set<Expression> inputs, Set<Pair<Slot, Slot>> equalPairs) { + ImmutableEqualSet.Builder<Slot> fromCastEqualSetBuilder = new ImmutableEqualSet.Builder<>(); + for (Expression input : inputs) { + if (!(input instanceof EqualTo)) { + continue; + } + EqualTo equalTo = (EqualTo) input; + Set<Slot> leftInputSlots = equalTo.left().getInputSlots(); + Set<Slot> rightInputSlots = equalTo.right().getInputSlots(); + // not support a=1 b=1 -> a=b, because Sometimes there are cases where the predicates a=1 and a=2 + // are not eliminated in time. After being pulled up, it is wrong to deduce a=b with b=1. + if (leftInputSlots.isEmpty() || rightInputSlots.isEmpty()) { + continue; + } + PredicateInferUtils.getPairFromCast((ComparisonPredicate) input) + .filter(pair -> pair.first instanceof Slot && pair.second instanceof Slot) + .ifPresent(pair -> { + Slot left = (Slot) pair.first; + Slot right = (Slot) pair.second; + fromCastEqualSetBuilder.addEqualPair(left, right); + equalPairs.add(left.getExprId().asInt() <= right.getExprId().asInt() + ? Pair.of(left, right) : Pair.of(right, left)); + }); + } + return fromCastEqualSetBuilder.build(); + } + + /** This is the exposed interface. Inputs are the input predicates for derivation. Review Comment: same as the deduceTransitiveEquality ########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ReplacePredicate.java: ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.common.Pair; +import org.apache.doris.nereids.CascadesContext; +import org.apache.doris.nereids.analyzer.Scope; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.rules.analysis.ExpressionAnalyzer; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.Like; +import org.apache.doris.nereids.trees.expressions.Not; +import org.apache.doris.nereids.trees.expressions.Or; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.ExpressionTrait; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.types.DecimalV2Type; +import org.apache.doris.nereids.types.DecimalV3Type; +import org.apache.doris.nereids.util.ImmutableEqualSet; +import org.apache.doris.nereids.util.PredicateInferUtils; +import org.apache.doris.nereids.util.TypeCoercionUtils; + +import com.google.common.collect.ImmutableList; +import org.jetbrains.annotations.Nullable; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/**ReplacePredicate*/ +public class ReplacePredicate { + private static List<Expression> getAllSubExpressions(Expression expr) { + List<Expression> subExpressions = new ArrayList<>(); + getAllSubExpressions(expr, subExpressions); + return subExpressions; + } + + private static void getAllSubExpressions(Expression expr, List<Expression> res) { + res.add(expr); + if (expr.children().size() != 1) { + Set<Slot> slots = expr.getInputSlots(); + if (slots.size() == 1) { + res.add(slots.iterator().next()); + } + return; + } + getAllSubExpressions(expr.child(0), res); + } + + /** fill map exprPredicates : expression and all its corresponding predicates */ + private static class PredicatesCollector extends ExpressionVisitor<Void, Map<Expression, Set<Expression>>> { + public static PredicatesCollector INSTANCE = new PredicatesCollector(); + + @Override + public Void visit(Expression expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitOr(Or expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitInPredicate(InPredicate inPredicate, Map<Expression, Set<Expression>> context) { + if (!validInPredicate(inPredicate)) { + return null; + } + for (Expression expr : getAllSubExpressions(inPredicate.getCompareExpr())) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(inPredicate); + } + return null; + } + + @Override + public Void visitComparisonPredicate(ComparisonPredicate comparisonPredicate, + Map<Expression, Set<Expression>> context) { + if (!validComparisonPredicate(comparisonPredicate)) { + return null; + } + // It is believed that 1<a has been rewritten as a>1 + for (Expression expr : getAllSubExpressions(comparisonPredicate.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(comparisonPredicate); + } + return null; + } + + @Override + public Void visitNot(Not not, Map<Expression, Set<Expression>> context) { + if (not.child(0) instanceof InPredicate && validInPredicate((InPredicate) not.child(0)) + || not.child(0) instanceof ComparisonPredicate + && validComparisonPredicate((ComparisonPredicate) not.child(0))) { + for (Expression expr : getAllSubExpressions(not.child(0).child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(not); + } + } + return null; + } + + @Override + public Void visitLike(Like like, Map<Expression, Set<Expression>> context) { + if (!(like.child(1) instanceof Literal)) { + return null; + } + for (Expression expr : getAllSubExpressions(like.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(like); + } + return null; + } + + private boolean validComparisonPredicate(ComparisonPredicate comparisonPredicate) { + return comparisonPredicate.right() instanceof Literal; + } + + private boolean validInPredicate(InPredicate inPredicate) { + return inPredicate.isLiteralChildren(); + } + } + + /* replaceToThis: find all predicates that replaceToThis can deduce (e.g. replaceToThis = b) + equalSet: the equivalent set of replaceToThis (e.g. equalSet: a=b) + exprPredicates: expression and all its corresponding predicates (e.g. such as {a: [a<10, a>1], b: [b in (1, 2)]}) + return: all predicates that replaceToThis can deduce (return b<10, b>1) */ + private static <T extends Expression> Set<Expression> getEqualSetAndDoReplace(T replaceToThis, Set<T> equalSet, + Map<? extends Expression, Set<Expression>> exprPredicates) { + ExpressionAnalyzer analyzer = new ReplaceAnalyzer(null, new Scope(ImmutableList.of()), null, false, false); + Set<Expression> res = new LinkedHashSet<>(); + for (T equals : equalSet) { + Map<Expression, Expression> replaceMap = new HashMap<>(); + replaceMap.put(equals, replaceToThis); + if (!exprPredicates.containsKey(equals)) { + continue; + } + for (Expression predicate : exprPredicates.get(equals)) { + Expression newPredicates = Replacer.INSTANCE.replace(predicate, replaceMap); + try { + Expression analyzed = analyzer.analyze(newPredicates); + res.add(analyzed.withInferred(true)); + } catch (Exception e) { + // has cast error, just not infer and do nothing + continue; + } + } + } + return res; + } + + /* Extract the equivalence relationship a=b, and when case (d_tinyint as int)=d_int is encountered, + remove the cast and extract d_tinyint=d_int + EqualPairs is the output parameter and the equivalent pair of predicate derivation input, + which is used to ensure that the derivation + does not generate repeated equivalent conditions, such as a=b and b=a */ + private static ImmutableEqualSet<Slot> findEqual(Set<Expression> inputs, Set<Pair<Slot, Slot>> equalPairs) { + ImmutableEqualSet.Builder<Slot> fromCastEqualSetBuilder = new ImmutableEqualSet.Builder<>(); + for (Expression input : inputs) { + if (!(input instanceof EqualTo)) { + continue; + } + EqualTo equalTo = (EqualTo) input; + Set<Slot> leftInputSlots = equalTo.left().getInputSlots(); + Set<Slot> rightInputSlots = equalTo.right().getInputSlots(); + // not support a=1 b=1 -> a=b, because Sometimes there are cases where the predicates a=1 and a=2 + // are not eliminated in time. After being pulled up, it is wrong to deduce a=b with b=1. + if (leftInputSlots.isEmpty() || rightInputSlots.isEmpty()) { + continue; + } + PredicateInferUtils.getPairFromCast((ComparisonPredicate) input) + .filter(pair -> pair.first instanceof Slot && pair.second instanceof Slot) + .ifPresent(pair -> { + Slot left = (Slot) pair.first; + Slot right = (Slot) pair.second; + fromCastEqualSetBuilder.addEqualPair(left, right); + equalPairs.add(left.getExprId().asInt() <= right.getExprId().asInt() + ? Pair.of(left, right) : Pair.of(right, left)); + }); + } + return fromCastEqualSetBuilder.build(); + } + + /** This is the exposed interface. Inputs are the input predicates for derivation. Review Comment: could this equal version infer function also use the graph based algr? No need to write this specific getEqualSetAndDoReplace to the infer action? ########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ReplacePredicate.java: ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.common.Pair; +import org.apache.doris.nereids.CascadesContext; +import org.apache.doris.nereids.analyzer.Scope; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.rules.analysis.ExpressionAnalyzer; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.Like; +import org.apache.doris.nereids.trees.expressions.Not; +import org.apache.doris.nereids.trees.expressions.Or; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.ExpressionTrait; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.types.DecimalV2Type; +import org.apache.doris.nereids.types.DecimalV3Type; +import org.apache.doris.nereids.util.ImmutableEqualSet; +import org.apache.doris.nereids.util.PredicateInferUtils; +import org.apache.doris.nereids.util.TypeCoercionUtils; + +import com.google.common.collect.ImmutableList; +import org.jetbrains.annotations.Nullable; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/**ReplacePredicate*/ +public class ReplacePredicate { + private static List<Expression> getAllSubExpressions(Expression expr) { + List<Expression> subExpressions = new ArrayList<>(); + getAllSubExpressions(expr, subExpressions); + return subExpressions; + } + + private static void getAllSubExpressions(Expression expr, List<Expression> res) { + res.add(expr); + if (expr.children().size() != 1) { + Set<Slot> slots = expr.getInputSlots(); + if (slots.size() == 1) { + res.add(slots.iterator().next()); + } + return; + } + getAllSubExpressions(expr.child(0), res); + } + + /** fill map exprPredicates : expression and all its corresponding predicates */ + private static class PredicatesCollector extends ExpressionVisitor<Void, Map<Expression, Set<Expression>>> { + public static PredicatesCollector INSTANCE = new PredicatesCollector(); + + @Override + public Void visit(Expression expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitOr(Or expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitInPredicate(InPredicate inPredicate, Map<Expression, Set<Expression>> context) { + if (!validInPredicate(inPredicate)) { + return null; + } + for (Expression expr : getAllSubExpressions(inPredicate.getCompareExpr())) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(inPredicate); + } + return null; + } + + @Override + public Void visitComparisonPredicate(ComparisonPredicate comparisonPredicate, + Map<Expression, Set<Expression>> context) { + if (!validComparisonPredicate(comparisonPredicate)) { + return null; + } + // It is believed that 1<a has been rewritten as a>1 + for (Expression expr : getAllSubExpressions(comparisonPredicate.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(comparisonPredicate); + } + return null; + } + + @Override + public Void visitNot(Not not, Map<Expression, Set<Expression>> context) { + if (not.child(0) instanceof InPredicate && validInPredicate((InPredicate) not.child(0)) + || not.child(0) instanceof ComparisonPredicate + && validComparisonPredicate((ComparisonPredicate) not.child(0))) { + for (Expression expr : getAllSubExpressions(not.child(0).child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(not); + } + } + return null; + } + + @Override + public Void visitLike(Like like, Map<Expression, Set<Expression>> context) { + if (!(like.child(1) instanceof Literal)) { + return null; + } + for (Expression expr : getAllSubExpressions(like.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(like); + } + return null; + } + + private boolean validComparisonPredicate(ComparisonPredicate comparisonPredicate) { + return comparisonPredicate.right() instanceof Literal; + } + + private boolean validInPredicate(InPredicate inPredicate) { + return inPredicate.isLiteralChildren(); + } + } + + /* replaceToThis: find all predicates that replaceToThis can deduce (e.g. replaceToThis = b) + equalSet: the equivalent set of replaceToThis (e.g. equalSet: a=b) + exprPredicates: expression and all its corresponding predicates (e.g. such as {a: [a<10, a>1], b: [b in (1, 2)]}) + return: all predicates that replaceToThis can deduce (return b<10, b>1) */ + private static <T extends Expression> Set<Expression> getEqualSetAndDoReplace(T replaceToThis, Set<T> equalSet, + Map<? extends Expression, Set<Expression>> exprPredicates) { + ExpressionAnalyzer analyzer = new ReplaceAnalyzer(null, new Scope(ImmutableList.of()), null, false, false); + Set<Expression> res = new LinkedHashSet<>(); + for (T equals : equalSet) { + Map<Expression, Expression> replaceMap = new HashMap<>(); + replaceMap.put(equals, replaceToThis); + if (!exprPredicates.containsKey(equals)) { + continue; + } + for (Expression predicate : exprPredicates.get(equals)) { + Expression newPredicates = Replacer.INSTANCE.replace(predicate, replaceMap); + try { + Expression analyzed = analyzer.analyze(newPredicates); + res.add(analyzed.withInferred(true)); + } catch (Exception e) { + // has cast error, just not infer and do nothing + continue; + } + } + } + return res; + } + + /* Extract the equivalence relationship a=b, and when case (d_tinyint as int)=d_int is encountered, + remove the cast and extract d_tinyint=d_int Review Comment: could we just use a set instead of a pair, to record the equality of multiple expr, such as a set with c1, c2, c3, to avoid using multiple entry to record c1, c2, c2? ########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ReplacePredicate.java: ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.common.Pair; +import org.apache.doris.nereids.CascadesContext; +import org.apache.doris.nereids.analyzer.Scope; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.rules.analysis.ExpressionAnalyzer; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.Like; +import org.apache.doris.nereids.trees.expressions.Not; +import org.apache.doris.nereids.trees.expressions.Or; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.ExpressionTrait; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.types.DecimalV2Type; +import org.apache.doris.nereids.types.DecimalV3Type; +import org.apache.doris.nereids.util.ImmutableEqualSet; +import org.apache.doris.nereids.util.PredicateInferUtils; +import org.apache.doris.nereids.util.TypeCoercionUtils; + +import com.google.common.collect.ImmutableList; +import org.jetbrains.annotations.Nullable; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/**ReplacePredicate*/ +public class ReplacePredicate { + private static List<Expression> getAllSubExpressions(Expression expr) { + List<Expression> subExpressions = new ArrayList<>(); + getAllSubExpressions(expr, subExpressions); + return subExpressions; + } + + private static void getAllSubExpressions(Expression expr, List<Expression> res) { + res.add(expr); + if (expr.children().size() != 1) { + Set<Slot> slots = expr.getInputSlots(); + if (slots.size() == 1) { + res.add(slots.iterator().next()); + } + return; + } + getAllSubExpressions(expr.child(0), res); + } + + /** fill map exprPredicates : expression and all its corresponding predicates */ + private static class PredicatesCollector extends ExpressionVisitor<Void, Map<Expression, Set<Expression>>> { + public static PredicatesCollector INSTANCE = new PredicatesCollector(); + + @Override + public Void visit(Expression expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitOr(Or expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitInPredicate(InPredicate inPredicate, Map<Expression, Set<Expression>> context) { + if (!validInPredicate(inPredicate)) { + return null; + } + for (Expression expr : getAllSubExpressions(inPredicate.getCompareExpr())) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(inPredicate); + } + return null; + } + + @Override + public Void visitComparisonPredicate(ComparisonPredicate comparisonPredicate, + Map<Expression, Set<Expression>> context) { + if (!validComparisonPredicate(comparisonPredicate)) { + return null; + } + // It is believed that 1<a has been rewritten as a>1 + for (Expression expr : getAllSubExpressions(comparisonPredicate.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(comparisonPredicate); + } + return null; + } + + @Override + public Void visitNot(Not not, Map<Expression, Set<Expression>> context) { + if (not.child(0) instanceof InPredicate && validInPredicate((InPredicate) not.child(0)) + || not.child(0) instanceof ComparisonPredicate + && validComparisonPredicate((ComparisonPredicate) not.child(0))) { + for (Expression expr : getAllSubExpressions(not.child(0).child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(not); + } + } + return null; + } + + @Override + public Void visitLike(Like like, Map<Expression, Set<Expression>> context) { + if (!(like.child(1) instanceof Literal)) { + return null; + } + for (Expression expr : getAllSubExpressions(like.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(like); + } + return null; + } + + private boolean validComparisonPredicate(ComparisonPredicate comparisonPredicate) { + return comparisonPredicate.right() instanceof Literal; + } + + private boolean validInPredicate(InPredicate inPredicate) { + return inPredicate.isLiteralChildren(); + } + } + + /* replaceToThis: find all predicates that replaceToThis can deduce (e.g. replaceToThis = b) + equalSet: the equivalent set of replaceToThis (e.g. equalSet: a=b) + exprPredicates: expression and all its corresponding predicates (e.g. such as {a: [a<10, a>1], b: [b in (1, 2)]}) + return: all predicates that replaceToThis can deduce (return b<10, b>1) */ + private static <T extends Expression> Set<Expression> getEqualSetAndDoReplace(T replaceToThis, Set<T> equalSet, + Map<? extends Expression, Set<Expression>> exprPredicates) { + ExpressionAnalyzer analyzer = new ReplaceAnalyzer(null, new Scope(ImmutableList.of()), null, false, false); + Set<Expression> res = new LinkedHashSet<>(); + for (T equals : equalSet) { + Map<Expression, Expression> replaceMap = new HashMap<>(); + replaceMap.put(equals, replaceToThis); + if (!exprPredicates.containsKey(equals)) { + continue; + } + for (Expression predicate : exprPredicates.get(equals)) { + Expression newPredicates = Replacer.INSTANCE.replace(predicate, replaceMap); + try { + Expression analyzed = analyzer.analyze(newPredicates); + res.add(analyzed.withInferred(true)); + } catch (Exception e) { + // has cast error, just not infer and do nothing + continue; + } + } + } + return res; + } + + /* Extract the equivalence relationship a=b, and when case (d_tinyint as int)=d_int is encountered, + remove the cast and extract d_tinyint=d_int Review Comment: why impl the ImmutableEqualSet using a map? looks a little strange... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
