feiniaofeiafei commented on code in PR #40878: URL: https://github.com/apache/doris/pull/40878#discussion_r1776752345
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/InferPredicates.java: ########## @@ -156,18 +159,22 @@ private Set<Expression> getAllExpressions(Plan left, Plan right, Optional<Expres Set<Expression> baseExpressions = pullUpPredicates(left); baseExpressions.addAll(pullUpPredicates(right)); condition.ifPresent(on -> baseExpressions.addAll(ExpressionUtils.extractConjunction(on))); - baseExpressions.addAll(PredicatePropagation.infer(baseExpressions)); - return baseExpressions; + return PredicateInferUtils.inferPredicate(baseExpressions); Review Comment: the former one can be removed, all reference of the old one has been replaced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org