gavinchou commented on code in PR #38811: URL: https://github.com/apache/doris/pull/38811#discussion_r1770851345
########## be/src/olap/options.cpp: ########## @@ -56,6 +56,9 @@ static std::string CACHE_QUERY_LIMIT_SIZE = "query_limit"; static std::string CACHE_NORMAL_PERCENT = "normal_percent"; static std::string CACHE_DISPOSABLE_PERCENT = "disposable_percent"; static std::string CACHE_INDEX_PERCENT = "index_percent"; +static std::string CACHE_STORAGE = "storage"; +static std::string CACHE_STORAGE_DISK = "disk"; +static std::string CACHE_STORAGE_MEMORY = "memory"; Review Comment: consider moving all file cache related options to file cache related scope (class) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
