gavinchou commented on code in PR #38811:
URL: https://github.com/apache/doris/pull/38811#discussion_r1770841672
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -91,14 +92,14 @@ BlockFileCache::BlockFileCache(const std::string&
cache_base_path,
_ttl_queue = LRUQueue(std::numeric_limits<int>::max(),
std::numeric_limits<int>::max(),
std::numeric_limits<int>::max());
- LOG(INFO) << fmt::format(
- "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
- "elements={}, query queue "
- "size={} elements={}",
- cache_base_path, cache_settings.disposable_queue_size,
- cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
- cache_settings.index_queue_elements,
cache_settings.query_queue_size,
- cache_settings.query_queue_elements);
+ if (cache_settings.storage == "memory") {
+ _storage = std::make_unique<MemFileCacheStorage>();
+ _cache_base_path = "memory";
+ } else {
+ _storage = std::make_unique<FSFileCacheStorage>();
+ }
+
+ LOG(INFO) << "file cache path= " << _cache_base_path <<
cache_settings.to_string();
Review Comment:
seems a space is missing after `_cache_base_path`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
