xzj7019 commented on code in PR #40819:
URL: https://github.com/apache/doris/pull/40819#discussion_r1759654929
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -276,7 +276,23 @@ public void mergeToNotOwnerRemove(GroupExpression target) {
this.getLowestCostTable()
.forEach((properties, pair) ->
target.updateLowestCostTable(properties, pair.second, pair.first));
// requestPropertiesMap
- target.requestPropertiesMap.putAll(this.requestPropertiesMap);
+ for (Map.Entry<PhysicalProperties, PhysicalProperties> entry :
requestPropertiesMap.entrySet()) {
Review Comment:
1）necessary to wrap it as a function, e.g, updateRequestPropertiesMap,
similar with updateLowestCostTable?
2) make sure it is the only invoking point which need to sync
LowestCostTable and RequestPropertiesMap during the whole group merging? like
replaceBestPlanProperty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
