morrySnow commented on code in PR #40819:
URL: https://github.com/apache/doris/pull/40819#discussion_r1764610086
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -276,7 +276,23 @@ public void mergeToNotOwnerRemove(GroupExpression target) {
this.getLowestCostTable()
.forEach((properties, pair) ->
target.updateLowestCostTable(properties, pair.second, pair.first));
// requestPropertiesMap
- target.requestPropertiesMap.putAll(this.requestPropertiesMap);
+ for (Map.Entry<PhysicalProperties, PhysicalProperties> entry :
requestPropertiesMap.entrySet()) {
Review Comment:
we have two point to update them. the other one is when we calculate cost
and enforcer. there are no common code between the two points, because we could
simply only update requestPropertiesMap when do updateLowestCostTable
successful in cost calculating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
