zhiqiang-hhhh commented on code in PR #40567:
URL: https://github.com/apache/doris/pull/40567#discussion_r1757121437
##########
be/src/vec/functions/function_string.h:
##########
@@ -2642,6 +2632,53 @@ class FunctionUrlDecode : public IFunction {
}
};
+class FunctionUrlEncode : public IFunction {
+public:
+ static constexpr auto name = "url_encode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlEncode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto res = ColumnString::create();
+ auto& res_offsets = res->get_offsets();
+ auto& res_chars = res->get_chars();
+ res_offsets.resize(input_rows_count);
+
+ ColumnPtr argument_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto* url_col =
check_and_get_column<ColumnString>(argument_column.get());
+
+ if (!url_col) {
Review Comment:
not necessary.
##########
be/src/vec/functions/function_string.h:
##########
@@ -2642,6 +2632,53 @@ class FunctionUrlDecode : public IFunction {
}
};
+class FunctionUrlEncode : public IFunction {
+public:
+ static constexpr auto name = "url_encode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlEncode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto res = ColumnString::create();
+ auto& res_offsets = res->get_offsets();
+ auto& res_chars = res->get_chars();
+ res_offsets.resize(input_rows_count);
+
+ ColumnPtr argument_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto* url_col =
check_and_get_column<ColumnString>(argument_column.get());
Review Comment:
assert_cast<ColumnString*> directly
##########
be/src/vec/functions/function_string.h:
##########
@@ -2642,6 +2632,53 @@ class FunctionUrlDecode : public IFunction {
}
};
+class FunctionUrlEncode : public IFunction {
+public:
+ static constexpr auto name = "url_encode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlEncode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto res = ColumnString::create();
+ auto& res_offsets = res->get_offsets();
+ auto& res_chars = res->get_chars();
+ res_offsets.resize(input_rows_count);
+
+ ColumnPtr argument_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto* url_col =
check_and_get_column<ColumnString>(argument_column.get());
+
+ if (!url_col) {
+ return Status::InternalError("Not supported input argument type");
+ }
+
+ std::string encoded_url;
+
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ auto source = url_col->get_data_at(i);
+ StringRef url_val(const_cast<char*>(source.data), source.size);
Review Comment:
result of get_data_at is already StringRef.
##########
be/src/util/url_coding.cpp:
##########
@@ -17,41 +17,21 @@
#include "util/url_coding.h"
+#include <curl/curl.h>
#include <libbase64.h>
-#include <math.h>
-#include <memory>
#include <sstream>
namespace doris {
-static inline void url_encode(const char* in, int in_len, std::string* out) {
- (*out).reserve(in_len);
- std::stringstream ss;
-
- for (int i = 0; i < in_len; ++i) {
- const char ch = in[i];
-
- // Escape the character iff a) we are in Hive-compat mode and the
- // character is in the Hive whitelist or b) we are not in
- // Hive-compat mode, and the character is not alphanumeric or one
- // of the four commonly excluded characters.
- ss << ch;
- }
-
- (*out) = ss.str();
-}
-
-void url_encode(const std::vector<uint8_t>& in, std::string* out) {
- if (in.empty()) {
- *out = "";
- } else {
- url_encode(reinterpret_cast<const char*>(&in[0]), in.size(), out);
+bool url_encode(const std::string& in, std::string* out) {
Review Comment:
maybe std::string_view is better
##########
be/src/vec/functions/function_string.h:
##########
@@ -2642,6 +2632,53 @@ class FunctionUrlDecode : public IFunction {
}
};
+class FunctionUrlEncode : public IFunction {
+public:
+ static constexpr auto name = "url_encode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlEncode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto res = ColumnString::create();
+ auto& res_offsets = res->get_offsets();
+ auto& res_chars = res->get_chars();
+ res_offsets.resize(input_rows_count);
+
+ ColumnPtr argument_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto* url_col =
check_and_get_column<ColumnString>(argument_column.get());
+
+ if (!url_col) {
+ return Status::InternalError("Not supported input argument type");
+ }
+
+ std::string encoded_url;
+
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ auto source = url_col->get_data_at(i);
+ StringRef url_val(const_cast<char*>(source.data), source.size);
+
+ if (!url_encode(url_val.to_string(), &encoded_url)) {
Review Comment:
is this behavior same with presto?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
