LiBinfeng-01 commented on PR #40567: URL: https://github.com/apache/doris/pull/40567#issuecomment-2345151721
> > should also implement fold constant on fe example: ExecutableFunctions.java : acos > > Done, and is there a way to test fold constant? you can add cases to nereids/p0/expression/fold_constant and need to check boundary: null, unnormal url string etc. like other guys mentions before, and use testFoldConst function in Suite.groovy to check whether the result of fe fold constant is same as be execution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
